Removed busyloop from SDL_GPUFence on MacOS#15223
Open
alexgu754 wants to merge 3 commits intolibsdl-org:mainfrom
Open
Removed busyloop from SDL_GPUFence on MacOS#15223alexgu754 wants to merge 3 commits intolibsdl-org:mainfrom
alexgu754 wants to merge 3 commits intolibsdl-org:mainfrom
Conversation
Before, MetalFence was implemented as simply a busy loop on an atomic int on metal, meaning the cpu would busy wait on the gpu to finish taking power from it and decreasing battery life. This was the only kind of cpu-gpu syncing (apart from requesting a swapchain) and it is rediculous.
alexgu754
force-pushed
the
macos-busyloop-fix
branch
from
2cb54b9 to
96af344
Compare
slouken
reviewed
Mar 17, 2026
slouken
reviewed
Mar 17, 2026
slouken
reviewed
Mar 17, 2026
Co-authored-by: Sam Lantinga <slouken@libsdl.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before, MetalFence was implemented as simply a busy loop on an atomic int on metal, meaning the cpu would busy wait on the gpu to finish taking power and resources from it and decreasing the battery life. This was the only kind of cpu-gpu syncing (apart from requesting a swapchain)
What's Implemented
This uses the commandbuffer's actual method [waitUntilCompletion] and .status