Open
Conversation
GCC: format '%p' expects argument of type 'void *', but argument n has type 'a' [-Wformat=]
format 'f' expects argument of type 'a', but argument n has type 'b' [-Wformat=]
…ence over real type
Narrowing conversion in testautomation_subsytems! SDL_INIT_* enum
Contributor
|
Didn't read the rest, but can you please lose the stupid |
This reverts commit be2b067.
Contributor
Author
|
Can't reproduce the build fails with emscripten. Set it up locally just to verify and debug but - as far as I can tell - the tests work. At least when run manually ... the automated setup with ctest doesn't work. But copied the launch commands and seeing the results in browser with all tests passing. Whats strange is that different test cases fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align and correct printf(-family) format string usage:
My assumption is version numbers are always unsigned. If this does not hold, this commit needs to be reverted.
I left out all the occurances where enum types are involved. They are in a follow up branch. The key doubt is about them being implementation-defined. GCC and Clang both choose uint types where possible, but can't say if this is true in all versions and standards and how other compilers handle it. Let me know if this should be PR'd as well.