fix(lxlweb): a11y NL160 (target size minimum) - #1664
Open
jesperengstrom wants to merge 1 commit into
Open
Conversation
jesperengstrom
marked this pull request as ready for review
August 24, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves
Report no: NL160
For our part the issue is links, or list of links, where the target size is not sufficient. Inline links are an exception to the target minimum rule, but when displayed next to each other as a list, the exception does not apply and vertical spacing between links must be sufficient.
My simple fix here is to set
.linkand.link-subtleto line-height 1.5rem. Setting a fixed line-height to variable text seems like a bad idea, but in practice it works quite well. Our links are (as far as i can tell) of sizes 12-16px. That gives a line-height of 2 to 12px links and 1.5 to 16px links, resulting in a 24px line overall.Some examples before/after:
/
/
Summary of changes