smb: enable for macOS / iOS builds & fix some libretro-common include usage #18652
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscd98
force-pushed
the
libsmb2-apple
branch
2 times, most recently
from
1d4f970 to
6f817f1
Compare
cscd98
changed the title
cscd98
force-pushed
the
libsmb2-apple
branch
3 times, most recently
from
fcc8056 to
7d2f439
Compare
cscd98
changed the title
cscd98
force-pushed
the
libsmb2-apple
branch
4 times, most recently
from
b8304e3 to
867d60c
Compare
Contributor
Author
|
@warmenhoven Any chance you can review this as the libretro-common updates need to get in. @joaodforce has (I think if its the same person on discord) tested this on apple devices 👍 |
Collaborator
|
I haven't had a chance to test out the Apple changes myself yet but did review the libretro-common change and that is good so I've cherry picked that to master, so the only thing remaining is the Apple specific bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
Now that libsmb2 is in griffin, we can use it for apple builds.
Its been added to baseconfig and RetroArch project files. This work is untested as I do not own a macbook.
Makes it more portable for libretro-common
Related Issues
Related Pull Requests
Reviewers
@warmenhoven