vfs: add retro_vfs_stat64_t #18633
Open
vfs: add retro_vfs_stat64_t #18633
+110
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscd98
force-pushed
the
stat64
branch
3 times, most recently
from
bea1942 to
13f8c8d
Compare
white-axe
reviewed
Jan 23, 2026
cscd98
force-pushed
the
stat64
branch
4 times, most recently
from
23cc579 to
8b4d2c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
The current stat implementation uses a 32-bit integer pointer which means files bigger than 2 GB are not supported. There is only 6 cores that use the 32-bit stat method that I could find however changing the existing function to 64-bit would break the ABI (requiring these cores to be updated):
https://github.com/search?q=org%3Alibretro+-%3Estat%28&type=code
So we add a new 64-bit version (alternative is to update those cores)
64-bit is needed dolphin which some ISOs are > 2 GB.
Tested with Dolphin (WIP) using VFS using new stat64 function
Tested with pre-built Quake loading over SMB
Tested with pre-build Visual Boy Advance (M) over SMB which uses old stat function
I have tested local files and SMB, but not SAF.
Tested on linux and android
Related Issues
Related Pull Requests
Reviewers