Skip to content

lime-system: wireless: add option distance_use_auto_if_available #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-gave wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lime-system: wireless: add option distance_use_auto_if_available #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/lime-docs/files/www/docs/lime-example.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ config lime wifi
# that rescan all available frequencies in active radios.

option unstuck_timeout '300' # Timeout in seconds that defines how long the mentioned above workaround should go.
option distance_use_auto_if_available true

#########################################################
### WiFi specific band options
Expand Down
1 change: 1 addition & 0 deletions packages/lime-system/files/etc/config/lime-defaults
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ config lime wifi
option ieee80211s_mesh_id 'LiMe'
option unstuck_interval '10'
option unstuck_timeout '300'
option distance_use_auto_if_available true

config lime-wifi-band '2ghz'
option channel '11'
Expand Down
51 changes: 50 additions & 1 deletion packages/lime-system/files/usr/lib/lua/lime/wireless.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ function wireless.configure()

local uci = config.get_uci_cursor()
uci:set("wireless", radioName, "disabled", 0)
uci:set("wireless", radioName, "distance", options["distance"])
uci:set("wireless", radioName, "distance", wireless.get_distance(radioName, options))
uci:set("wireless", radioName, "noscan", 1)
uci:set("wireless", radioName, "channel", channel)
if options["country"] then uci:set("wireless", radioName, "country", options["country"]) end
Expand All @@ -238,6 +238,8 @@ function wireless.configure()
and (not key:match("distance"))
and (not key:match("unstuck_interval"))
and (not key:match("unstuck_timeout"))
and (not key:match("dynack"))
and (not key:match("phy_macaddr"))
and (not (wireless.isMode(keyPrefix) and keyPrefix ~= modeName)))
if isGoodOption then
local nk = key:gsub("^"..modeName.."_", "")
Expand Down Expand Up @@ -322,4 +324,51 @@ function wireless.set_band_config(band, cfg)
utils.unsafe_shell('lime-config')
end

--! Check if the driver supports dynack.
--! At firstboot run 'iw phyX set distance auto'. Rely on the iw error i.e. 'command failed: Not supported (-95)'
--! and save the result in lime-autogen i.e. lime-autogen.radio0.dynack=0
--! Re run on the same phy when the macaddress has changed i.e. in case of plugging a different usb wireless adapter
function wireless.is_distance_auto_available(radioName)
local phy = "phy"..utils.indexFromName(radioName)
local phy_mac = utils.unsafe_shell("cat /sys/class/ieee80211/"..phy.."/macaddress 2>/dev/null"):gsub("\n","")
local uci = config.get_uci_cursor()

uci:set(config.UCI_AUTOGEN_NAME, radioName, "wifi")
--! mac unchanged
if (phy_mac == uci:get(config.UCI_AUTOGEN_NAME, radioName, "phy_macaddr")) then
if uci:get(config.UCI_AUTOGEN_NAME, radioName, "dynack") ~= nil then
return uci:get(config.UCI_AUTOGEN_NAME, radioName, "dynack")
end
end

local iw_cmd = utils.unsafe_shell("iw "..phy.." set distance auto 2>/dev/null; echo $(( $? == 0 ))"):gsub("\n","")
uci:set(config.UCI_AUTOGEN_NAME, radioName, "phy_macaddr", phy_mac)
uci:set(config.UCI_AUTOGEN_NAME, radioName, "dynack", iw_cmd)
uci:commit(config.UCI_AUTOGEN_NAME)
return iw_cmd
end

--! If distance 'auto' is requested for a driver that does not support it,
--! use the lime-defaults value as safer option than allowing to set "auto"
--! which could lead to the minimum being applied at next reboot
--! potentially compromising long distance wireless links.
function wireless.apply_distance_auto_fallback(radioName,options)
if options["distance"] ~= "auto" then return options["distance"] end
local uci = config.get_uci_cursor()
local band = wireless.getRadioBand(radioName)
local distance_default = uci:get(config.UCI_DEFAULTS_NAME, band, "distance")
print('WARNING: wireless.get_distance: invalid "option distance \'auto\'" for '..band..' '..radioName..
'. Fallback to lime-defaults value: '.. distance_default)
return distance_default
end

function wireless.get_distance(radioName, options)
--! distance auto requested or enforced
if (options["distance"] == "auto" or options["distance_use_auto_if_available"] == 'true') then
if wireless.is_distance_auto_available(radioName) == '1' then return "auto"
else return wireless.apply_distance_auto_fallback(radioName,options) end
--! distance set
else return options["distance"] end
end

return wireless