refactor: add closeRead and reset tests to compliance suite#3361
refactor: add closeRead and reset tests to compliance suite#3361lalitcap23 wants to merge 3 commits intolibp2p:mainfrom
Conversation
|
These tests shouldn't just be copied over, they should be adapted to fit with the tests they are being moved into. Be sure to only add test coverage, something covered in the previous tests and missing in the new ones. It looks like some of the copied tests were already covered. Be sure to identify what coverage is missing, if any, and add it to an existing or new test. After that remove the currently skipped portions from the webrtc stream tests. |
|
@tabcat , can review it . |
|
These tests shouldn't just be copied over, they should be adapted to fit with the tests they are being moved into. Be sure to only add test coverage, something covered in the previous tests and missing in the new ones. It looks like some of the copied tests were already covered. Be sure to identify what coverage is missing, if any, and add it to an existing or new test. |
|
@tabcat , (sorry for showing up so late )Hi , I tested the changes and all tests pass (verified with mplex compliance suite). |
Summary
Adds
closeReadandresetbehavior tests to the stream muxer compliance test suite.Changes
closes read onlytest to compliance suiteresets when remote abortstest to compliance suiteWhy
These tests validate generic stream behavior (half-closing and reset handling) that should be consistent across all stream muxer implementations (Yamux, Mplex, etc.), not just WebRTC.
Adding them to the compliance suite ensures all implementations handle these cases correctly.
Testing
The tests follow the same style as the existing ones and work directly with the generic Stream interface.
Fixes #3360