logger: fix crash and undefined behavior in logger_dump_hex with zero-length buffers#776
Merged
nikias merged 1 commit intolibimobiledevice:masterfrom Feb 16, 2026
Merged
Conversation
Member
|
Would you mind squashing the commits? |
dde09ce to
6163635
Compare
Contributor
Author
|
Squashed commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix undefined behavior and potential crash in logger_dump_hex() when called with a zero-length buffer.
Previously, the function allocated a 1-byte buffer but did not initialize it. This uninitialized buffer was later passed to %s formatting functions, causing an out-of-bounds read until a random null terminator was encountered. On Windows, this could trigger an access violation and crash the process.
This situation can occur when dumping nonces or other binary data if the reported length is zero due to device communication issues or unexpected conditions.