Skip to content

Make file + line members of InlineInfo required#1554

Merged
d-e-s-o merged 1 commit intolibbpf:mainfrom
d-e-s-o:topic/gsym-req
Apr 24, 2026
Merged

Make file + line members of InlineInfo required#1554
d-e-s-o merged 1 commit intolibbpf:mainfrom
d-e-s-o:topic/gsym-req

Conversation

@d-e-s-o
Copy link
Copy Markdown
Collaborator

@d-e-s-o d-e-s-o commented Apr 24, 2026

With commit cda702e ("Introduce InlineInfo::skip() helper for Gsym logic") we simplified some of the Gsym inline parsing logic. As a result of this change, we don't actually need the call_file & call_line member of the InlineInfo type to be optional. So make them required now.

With commit cda702e ("Introduce InlineInfo::skip() helper for Gsym
logic") we simplified some of the Gsym inline parsing logic. As a result
of this change, we don't actually need the call_file & call_line member
of the InlineInfo type to be optional. So make them required now.

Signed-off-by: Daniel Müller <[email protected]>
@d-e-s-o d-e-s-o enabled auto-merge (rebase) April 24, 2026 17:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.52%. Comparing base (bf0766b) to head (4b5521d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1554      +/-   ##
==========================================
+ Coverage   95.50%   95.52%   +0.02%     
==========================================
  Files          56       56              
  Lines        9551     9549       -2     
==========================================
  Hits         9122     9122              
+ Misses        429      427       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-e-s-o d-e-s-o merged commit a06c0b0 into libbpf:main Apr 24, 2026
46 checks passed
@d-e-s-o d-e-s-o deleted the topic/gsym-req branch April 24, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant