Propogate LDFLAGS and other user-supplied options#1168
Open
mr-c wants to merge 1 commit intolh3:masterfrom
Open
Propogate LDFLAGS and other user-supplied options#1168mr-c wants to merge 1 commit intolh3:masterfrom
mr-c wants to merge 1 commit intolh3:masterfrom
Conversation
Contributor
|
LDFLAGS naturally goes alongside CFLAGS, not at the end of the command. |
Co-authored-by: Michael R. Crusoe <crusoe@debian.org>
Author
|
Good point @jmarshall , thanks! |
Contributor
|
It goes alongside the other flag options on the commands that are doing linking. All those *.o recipes should not include |
lh3
reviewed
Mar 12, 2024
|
|
||
| ksw2_extz2_sse41.o:ksw2_extz2_sse.c ksw2.h kalloc.h | ||
| $(CC) -c $(CFLAGS) -msse4.1 $(CPPFLAGS) -DKSW_CPU_DISPATCH $(INCLUDES) $< -o $@ | ||
| $(CC) -c $(CFLAGS) $(LDFLAGS) -msse4.1 $(CPPFLAGS) -DKSW_CPU_DISPATCH $(INCLUDES) $< -o $@ |
Owner
There was a problem hiding this comment.
Do we need LDFLAGS for compiling? I thought this flag is only used for linking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use this patch for the Debian package of minimap2.