Added filenames to "Unmatched SAI magic" message#20
Open
zestrada wants to merge 1 commit intolh3:masterfrom
Open
Added filenames to "Unmatched SAI magic" message#20zestrada wants to merge 1 commit intolh3:masterfrom
zestrada wants to merge 1 commit intolh3:masterfrom
Conversation
mvdbeek
pushed a commit
to mvdbeek/bwa
that referenced
this pull request
Nov 9, 2017
ONT source code changes to compile with MSVC 14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was helpful for me debugging a problem so I thought others may find it useful. I realize that the loop over two files may seem silly to some, but it made sense from a "DRY" perspective since I wanted to output which file did not have the magic number.
Here's an example: