feat: add kafka connection#4036
Open
Yisaer wants to merge 5 commits intolf-edge:masterfrom
Open
Conversation
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Kafka named connection support and allow Kafka sink configs to reuse broker connection settings through
connectionSelector.Changes
Added a stateless Kafka connection implementation.
kafka-godial as the health check.kafkaconnection provider when the Kafka implementation package is loaded.Updated Kafka sink metadata.
connectionSelector.Added test coverage.
connectionSelector.memory source -> Kafka sinkusing a Kafka named connection.Added Kafka FVT as a standalone test job in the main test workflow.
connectionSelector + topic.Verification
go test ./extensions/impl/kafka -run 'TestKafkaConnection'go test ./internal/topo/node/conf -run TestOverwriteKafkaConnectionPropsgo test -trimpath -tags='full deadlock' -count=1 -v ./fvt -run TestKafkaConnectionSelectorSinkE2Ego test -tags full ./internal/binder/iopython3 -m json.tool extensions/sinks/kafka/kafka.jsonNote: The final workflow-only adjustment was pushed without rerunning local tests per maintainer request.