admin: Implement missing dryRunRAC methods #8589
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
requested review from
a team and
jsha
and removed request for
a team
jsha
requested changes
Jan 21, 2026
| return &emptypb.Empty{}, nil | ||
| } | ||
|
|
||
| var _ rapb.RegistrationAuthorityClient = (*dryRunRAC)(nil) |
Contributor
There was a problem hiding this comment.
This duplicates line 16 above. Perhaps it was meant to apply to dryRunSAC?
Also the PR title says RAC but the PR description says SAC.
Contributor
|
This appears to be a duplicate of #8579 ? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement dryRunSAC methods AddRateLimitOverride, DisableRateLimitOverride, EnableRateLimitOverride, and GetEnabledRateLimitOverrides. This avoids a panic when running the admin tool subcommands import-limit-overrides, dump-limit-overrides, add-limit-override, and toggle-limit-override.
Fixes #8588