sa: deprecate two feature flags #8580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoreAuthzsInOrders and StoreARIReplacesInOrders have been deployed in prod. Also, ensure both flags are set in `config/sa.json`, and neither is set in `config-next/sa.json`. This removes all reads of the `orderToAuthz2` table, which will make it possibel to drop the table.
Contributor
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
1 similar comment
Contributor
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
Contributor
Author
|
Thanks bot! The configuration and SQL changes have already been made in prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StoreAuthzsInOrders and StoreARIReplacesInOrders have been deployed in prod.
Also, ensure both flags are set in
config/sa.json, and neither is set inconfig-next/sa.json.This removes all reads of the
orderToAuthz2table, which will make it possibel to drop the table.