Jitter the ARI Retry-After header amount 20% either side of 6 hours #8576
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maen-bn
force-pushed
the
add-jitter-ari-retry-after-header
branch
from
421c5f7 to
b2251a1
Compare
nmxhc
reviewed
Jan 22, 2026
| factor := 0.2 * (2*rand.Float64() - 1) | ||
| jittered := int(float64(base) * (1 + factor)) | ||
|
|
||
| if jittered < 0 { |
There was a problem hiding this comment.
Hi,
I think that this condition should never be met for positive inputs since then jittered>base*0.8>0.
For negative inputs however, this creates an infinite recursion (up to rounding errors for bases close to 0) since jittered<base*0.8<0.
From my understanding of the context, I suggest to remove this branch and adjust the comment.
aarongable
reviewed
Jan 23, 2026
| // createJitter will return a random integer within a 20% window of the base that is provided. | ||
| // If the jittered amount is a negative number, the jitter is retried until a positive | ||
| // number is generated | ||
| func createJitter(base int) int { |
Contributor
There was a problem hiding this comment.
Two minor comments:
- Since this is a hyper-specific helper function, it might be cleaner for this function to take a time.Duration as input and return a string-formatted integer. Then it could simply be called like
response.Header().Set(headerRetryAfter, jitterHeader(6 * time.Hour))
- The check for negative numbers is a bug. Even if the input is just 1, it should be impossible for this function to return anything less than 0. And if the input is negative, this will loop infinitely. I'd remove the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8558