RA: Simplify sending validation records to the SA #8569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary abstraction from the RA as it receives validation records and problems from the VA, and forwards them to the SA for storage. Instead of converting everything from protobufs to core objects, then modifying other core objects in place, then extracting fields from those core objects to convert back to protobufs... simply pass through the existing protobufs unchanged. This removes about 40 lines from the RA, including a whole helper function, greatly simplifying its asynchronous background validation goroutine.
As a result of deleting the helper function, we lose some test coverage of a particular double-validation race case. But that test never should have been in the RA in the first place (it's asserting that the RA gets the right error code back from the SA), so replace it with an equivalent test in the SA.