-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[LOG] Adding a filter for the weblog #5484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mega
Are you sure you want to change the base?
Conversation
|
Should i also change the functions in |
That FR: Can this search (also) handle wildcards or regular expressions? |
No, I wanted it to be as simple and small as possible, but this can surely be added.
This is basically included since it filters also phrases. At least in my understanding. |
|
I might want to add an option to show an x number of lines after a matching line. But not sure how to flag this as an option in the filter field (also not sure if it is really necessary. I am actually quite happy with how it works now). |
|
You could also add a CTRL-F like option to move to the lines and then add an attribute to those lines to highlight the parts where it occurs. |
The intent is to have the console log nicely aligned, but 5 characters is not enough to hold |
|
Ok.. for now we have: I chose this over standard regex so that mere mortal people can use it too. :) |
|
The idea of the So that's also one reason why I was thinking about splitting this into something else. The idea was to allow for filtering, but now you already have that part 'solved'... ;) |
|
Ah, now we're going somewhere 😆 Just waiting for the code changes 😉 |
Comes tomorrow. Right now, I have to find a movie. Which takes all my resources :) |
If you can't find it, you can watch a YouTube short... and then continue ;) |
- Added highlight filter phrases - Added ordered AND operator (&) - Added exclusion (!)
|
Ok, I just committed all the changes. It would be nice if somebody could test it. Also: I am not sure if highlighting is really necessary. If you like it, we keep it. |
|
Well it is hard to add 'context'. N.B. did you notice you now also get the web log from boot when you access it within 30 sec after boot? (on ESP32, ESP8266 does have a shorter TTL for log entries) |
- Added a check to determine if there is already a filter field present; otherwise, add one for older builds.
|
I added a bit of code so that every build can make use of the filter. The script checks first if there is a filter field and if not injects it via the script. |
|
Can you also make a commit which removes that one file which is not part of this PR? |
BTW: This is really cool and helpful! :) |



Made a filter. It was easier than I thought :)
Should I make the changes optional/custom?
;.!.&.