Migrate according to new hooks architecture in PR#12879#216
Open
ozer550 wants to merge 5 commits intolearningequality:mainfrom
Open
Migrate according to new hooks architecture in PR#12879#216ozer550 wants to merge 5 commits intolearningequality:mainfrom
ozer550 wants to merge 5 commits intolearningequality:mainfrom
Conversation
rtibbles
reviewed
Mar 11, 2026
Member
rtibbles
left a comment
There was a problem hiding this comment.
One thing that needs to be retained.
| self.create_hidden_window() | ||
|
|
||
| enable_plugin("kolibri.plugins.app") | ||
| enable_plugin("kolibri_app") |
Member
There was a problem hiding this comment.
We still need to enable the plugin from this repository! Just not the kolibri one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated kolibri-app to work with Kolibri PR #12879, which removed the old app plugin and replaced it with a hook-based system.
References
closes #212
Reviewer guidance
For Ubuntu:
sudo apt install python3.10-venv python3.10-devmake dependencies.whlartifact from the CI buildwhl/directory (in kolibri_app):mkdir -p whlcp /path/to/downloaded/kolibri-*.whl whl/make install-whl whl=whl/kolibri-<version>.whlmake run-dev