fix: don't resolve deps as part of lake exe cache query step#748
Merged
mhuisi merged 1 commit intoleanprover:masterfrom Mar 31, 2026
Merged
fix: don't resolve deps as part of lake exe cache query step#748mhuisi merged 1 commit intoleanprover:masterfrom
lake exe cache query step#748mhuisi merged 1 commit intoleanprover:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the Lake dependency resolution in several of the project commands in the extension to a separate step with its own description. This ensures that it doesn't accidentally happen as part of another step that seems much cheaper (e.g.
lake exe cache, which we use to check whether a project is a Mathlib project).