-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - chore: mark Ordinal.enumOrd with no_expose
#33298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 74bdd8deffImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
ocfnash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly that this definition is essentially an implementation detail en route to enumOrdOrderIso? If so could we add that to the doc string?
|
Yep, that's correct. I'll add it to the docstring. |
|
bors merge |
The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.
|
Pull request successfully merged into master. Build succeeded: |
Ordinal.enumOrd with no_exposeOrdinal.enumOrd with no_expose
…33298) The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.
…33298) The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.
The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.