Skip to content

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 26, 2025

The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Dec 26, 2025
@github-actions github-actions bot added the t-set-theory Set theory label Dec 26, 2025
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

PR summary 74bdd8deff

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Dec 26, 2025
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that this definition is essentially an implementation detail en route to enumOrdOrderIso? If so could we add that to the doc string?

@vihdzp
Copy link
Collaborator Author

vihdzp commented Jan 2, 2026

Yep, that's correct. I'll add it to the docstring.

@ocfnash
Copy link
Contributor

ocfnash commented Jan 5, 2026

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 5, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 5, 2026
The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 5, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: mark Ordinal.enumOrd with no_expose [Merged by Bors] - chore: mark Ordinal.enumOrd with no_expose Jan 5, 2026
@mathlib-bors mathlib-bors bot closed this Jan 5, 2026
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
…33298)

The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…33298)

The definition is an implementation detail, and this function is fully characterized by being an order isomorphism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants