Skip to content

Comments

Allow specifying annotations on ArgoCD projects#48

Merged
Dragemil merged 5 commits intomainfrom
feature/annotations-on-argo-projects
Oct 9, 2025
Merged

Allow specifying annotations on ArgoCD projects#48
Dragemil merged 5 commits intomainfrom
feature/annotations-on-argo-projects

Conversation

@Dragemil
Copy link
Contributor

@Dragemil Dragemil commented Oct 2, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom annotations on ArgoCD applications to enable notification configurations. The change allows users to specify annotations like those needed for ArgoCD notifications to Slack as mentioned in the ArgoCD documentation.

  • Adds a new annotations variable to accept custom annotations for ArgoCD applications
  • Updates the ArgoCD application resource to use the provided annotations
  • Documents the new variable in the module readme

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
argocd_app/variables.tf Adds new annotations variable with map(string) type and empty default
argocd_app/app.tf Applies the annotations variable to the ArgoCD application metadata
argocd_app/readme.md Documents the new annotations input parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marcin-dardzinski
Copy link
Member

Since we're configuring it for our needs, maybe it's better to have a more specific optional slack_notifications_channel param.

Generic labels/annotation could be kept as well for any extravagant needs

@Dragemil Dragemil merged commit b173a84 into main Oct 9, 2025
3 checks passed
@Dragemil Dragemil deleted the feature/annotations-on-argo-projects branch October 9, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants