Allow specifying annotations on ArgoCD projects#48
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom annotations on ArgoCD applications to enable notification configurations. The change allows users to specify annotations like those needed for ArgoCD notifications to Slack as mentioned in the ArgoCD documentation.
- Adds a new
annotationsvariable to accept custom annotations for ArgoCD applications - Updates the ArgoCD application resource to use the provided annotations
- Documents the new variable in the module readme
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| argocd_app/variables.tf | Adds new annotations variable with map(string) type and empty default |
| argocd_app/app.tf | Applies the annotations variable to the ArgoCD application metadata |
| argocd_app/readme.md | Documents the new annotations input parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Since we're configuring it for our needs, maybe it's better to have a more specific optional Generic labels/annotation could be kept as well for any extravagant needs |
marcin-dardzinski
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/subscriptions/
Our slack sender should be configured?