Skip to content

Android patrol flag - #3181

Open
Polyphemus980 wants to merge 2 commits into
masterfrom
feat/android-patrol-enabled-gradle-flag
Open

Android patrol flag#3181
Polyphemus980 wants to merge 2 commits into
masterfrom
feat/android-patrol-enabled-gradle-flag

Conversation

@Polyphemus980

Copy link
Copy Markdown
Contributor

Add a patrol-enabled flag to gradle invocation so apps can detect patrol builds. This can be used e.g. for conditional dependencies

@github-actions github-actions Bot added the package: patrol_cli Related to the patrol_cli package label Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Gradle property '-Ppatrol-enabled=true' to Android builds so apps can detect a Patrol build. However, several test assertions in 'app_options_test.dart' incorrectly use an underscore ('-Ppatrol_enabled=true') instead of a hyphen, which will cause the tests to fail. The reviewer has correctly identified these mismatches and provided suggestions to fix them.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/patrol_cli/test/crossplatform/app_options_test.dart Outdated
Comment thread packages/patrol_cli/test/crossplatform/app_options_test.dart Outdated
Comment thread packages/patrol_cli/test/crossplatform/app_options_test.dart Outdated
Comment thread packages/patrol_cli/test/crossplatform/app_options_test.dart Outdated
@Polyphemus980
Polyphemus980 force-pushed the feat/android-patrol-enabled-gradle-flag branch from 8f3748f to 77cc861 Compare July 21, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: patrol_cli Related to the patrol_cli package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant