Android patrol flag - #3181
Open
Polyphemus980 wants to merge 2 commits into
Open
Conversation
Polyphemus980
requested review from
Kendru98,
PiotrRogulski,
jBorkowska,
pdenert,
piotruela and
zoskar
as code owners
July 21, 2026 11:21
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Gradle property '-Ppatrol-enabled=true' to Android builds so apps can detect a Patrol build. However, several test assertions in 'app_options_test.dart' incorrectly use an underscore ('-Ppatrol_enabled=true') instead of a hyphen, which will cause the tests to fail. The reviewer has correctly identified these mismatches and provided suggestions to fix them.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Polyphemus980
force-pushed
the
feat/android-patrol-enabled-gradle-flag
branch
from
July 21, 2026 11:24
8f3748f to
77cc861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a patrol-enabled flag to gradle invocation so apps can detect patrol builds. This can be used e.g. for conditional dependencies