Skip to content

[patrol_cli] Upgrade package_config - #3154

Draft
PiotrRogulski wants to merge 12 commits into
masterfrom
chore/upgrade-package_config
Draft

[patrol_cli] Upgrade package_config#3154
PiotrRogulski wants to merge 12 commits into
masterfrom
chore/upgrade-package_config

Conversation

@PiotrRogulski

Copy link
Copy Markdown
Member

To resolve the dependency conflicts, I also had to remove build_runner from dev deps (it wasn't used anyway) and upgrade leancode_lint to use the new analyzer.

@github-actions github-actions Bot added the package: patrol_cli Related to the patrol_cli package label Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum Dart SDK constraint to >=3.9.0 <4.0.0, upgrades several dependencies (including package_config and leancode_lint), and removes build_runner and custom_lint from dev_dependencies. It also removes the custom_lint plugin from analysis_options.yaml. The review feedback highlights that removing custom_lint from both the analysis options and dependencies will completely disable the custom lint rules from leancode_lint, as analyzer plugins are not transitively inherited. It is recommended to retain and upgrade custom_lint to a compatible version instead of removing it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/patrol_cli/analysis_options.yaml (3-5)

medium

In Dart, analyzer plugins (such as custom_lint) are not transitively inherited from included analysis options files (like package:leancode_lint/analysis_options.yaml). Removing the custom_lint plugin from this file will completely disable all custom lint rules provided by leancode_lint. If you want to keep using the custom lints from leancode_lint, you must retain the custom_lint plugin in analysis_options.yaml and keep custom_lint in your dev_dependencies.

packages/patrol_cli/pubspec.yaml (44)

medium

Removing custom_lint from dev_dependencies will prevent the custom_lint analyzer plugin from being resolved and executed, disabling all custom rules from leancode_lint. If the removal was due to dependency conflicts with custom_lint: ^0.8.1, consider upgrading custom_lint to a newer version compatible with Dart 3.9.0 and leancode_lint: ^24.0.0 instead of removing it entirely.

@PiotrRogulski
PiotrRogulski marked this pull request as draft July 10, 2026 20:57
@github-actions github-actions Bot added the package: patrol Related to the patrol package (native automation, test bundling) label Jul 13, 2026
@github-actions github-actions Bot added the package: adb Related to the adb package label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: adb Related to the adb package package: patrol_cli Related to the patrol_cli package package: patrol Related to the patrol package (native automation, test bundling)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant