[patrol_cli] Upgrade package_config - #3154
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the minimum Dart SDK constraint to >=3.9.0 <4.0.0, upgrades several dependencies (including package_config and leancode_lint), and removes build_runner and custom_lint from dev_dependencies. It also removes the custom_lint plugin from analysis_options.yaml. The review feedback highlights that removing custom_lint from both the analysis options and dependencies will completely disable the custom lint rules from leancode_lint, as analyzer plugins are not transitively inherited. It is recommended to retain and upgrade custom_lint to a compatible version instead of removing it.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/patrol_cli/analysis_options.yaml (3-5)
In Dart, analyzer plugins (such as custom_lint) are not transitively inherited from included analysis options files (like package:leancode_lint/analysis_options.yaml). Removing the custom_lint plugin from this file will completely disable all custom lint rules provided by leancode_lint. If you want to keep using the custom lints from leancode_lint, you must retain the custom_lint plugin in analysis_options.yaml and keep custom_lint in your dev_dependencies.
packages/patrol_cli/pubspec.yaml (44)
Removing custom_lint from dev_dependencies will prevent the custom_lint analyzer plugin from being resolved and executed, disabling all custom rules from leancode_lint. If the removal was due to dependency conflicts with custom_lint: ^0.8.1, consider upgrading custom_lint to a newer version compatible with Dart 3.9.0 and leancode_lint: ^24.0.0 instead of removing it entirely.
To resolve the dependency conflicts, I also had to remove
build_runnerfrom dev deps (it wasn't used anyway) and upgradeleancode_lintto use the new analyzer.