fix: Dynamic port selection flow on Android - #2636
Closed
piotruela wants to merge 17 commits into
Closed
Conversation
piotruela
requested review from
fylyppo,
gogolon,
mateuszwojtczak and
pdenert
as code owners
May 21, 2025 20:13
|
To view this pull requests documentation preview, visit the following URL: docs.page/leancodepl/patrol~2636 Documentation is deployed and generated using docs.page. |
github-actions
Bot
added
package: patrol_cli
Contributor
|
Hi, would be awesome if this PR can be completed :) Atm we cannot run the tests with latest flutter in our pipeline |
Collaborator
This was already published in patrol_cli: 3.6.0: https://pub.dev/packages/patrol_cli/changelog#360. |
added 8 commits
June 11, 2025 16:02
piotruela
changed the title
Collaborator
Author
|
Replaced by #3173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes reported bugs on dynamic port selection solution.
NativeAutomatorgets the test server port from within the constructor. Because of that,NativeAutomatorConfig.portwas deprecated. It should not be possible to manually set theportvalue.--debugflag toflutter build --config-onlyinvocation to preventPatrolPluginbeing removed from the app code.Also fixes #2614.