Conversation
…hods Agent-Logs-Url: https://github.com/lc-soft/LCUI/sessions/31fedd8b-88fb-48dd-b055-303325c02c73 Co-authored-by: lc-soft <1730073+lc-soft@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lc-soft
April 29, 2026 14:12
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pd_image_readerswas a variable-length array whose entries shifted depending on which backend libraries (libpng,libjpeg) were compiled in, forcingpd_image_reader_get_methodsto do a linear scan matching ontypeto find the right entry.Changes
Fixed-index array —
pd_image_readersis nowpd_image_reader_methods_t pd_image_readers[PD_READER_COUNT]using C99 designated initializers, sotype value == array index:Absent-library slots are zero-initialized (all-NULL pointers) — no missing symbol references at link time.
O(1)
pd_image_reader_get_methods— removes theforloop; direct index access with two guards:type <= PD_UNKNOWN_READER || type >= PD_READER_COUNT→NULL!m->create→NULL(catches zero-initialized absent-library slots)pd_image_reader_detect_suffix— iteration now skips entries wheresuffix == NULL, preventingstrstr(NULL, …)on zero-initialized slots.