fix: category text contrast in light mode - #7797
Conversation
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
|
Preview deployment for PR #7797 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
|
@Sbragul26 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
Attach video & also add root cause please |
|
@Sbragul26 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
KumarNirupam1
left a comment
There was a problem hiding this comment.
Looks good to me. The previous use of whiteToBlack could lead to poor contrast in light mode because the selected chip uses a dark green background. Switching both the selected category text and integration title to theme.white provides consistent readability across themes. I tested the affected states and the change looks correct.
LGTM 👍
📝 WalkthroughWalkthroughThis change updates text color properties in Integration.style.js. The ChangesText Color Fix
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/sections/Meshery/Meshery-integrations/Integration.style.js`:
- Line 107: Update the `.title` color declaration in the styled component to use
a theme color that provides WCAG 2.1 AA contrast against the hover background
`#00d3a9` in both themes, while preserving the existing hover styling.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0d52a75e-77ce-4b05-87cb-f9c23a796d6f
📒 Files selected for processing (1)
src/sections/Meshery/Meshery-integrations/Integration.style.js
| .title { | ||
| line-height: 1.375rem; | ||
| color: ${(props) => props.theme.whiteToBlack}; | ||
| color: ${(props) => props.theme.white}; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Restore WCAG-compliant contrast for .title.
When the card is hovered, Line 147 sets the background to #00d3a9. theme.white does not provide sufficient contrast on that background. Use a theme value that meets WCAG AA in both modes, or change the hover background.
As per coding guidelines, JavaScript changes must meet WCAG 2.1 Level AA accessibility requirements.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/sections/Meshery/Meshery-integrations/Integration.style.js` at line 107,
Update the `.title` color declaration in the styled component to use a theme
color that provides WCAG 2.1 AA contrast against the hover background `#00d3a9`
in both themes, while preserving the existing hover styling.
Source: Coding guidelines


Description
This PR fixes #7796 and improves the visibility of category filter labels on the Integrations page in Light Mode.
Signed commits
Summary by CodeRabbit