Skip to content

fix: category text contrast in light mode - #7797

Open
Sbragul26 wants to merge 6 commits into
layer5io:masterfrom
Sbragul26:fix/category-text-visibility-light-mode
Open

fix: category text contrast in light mode#7797
Sbragul26 wants to merge 6 commits into
layer5io:masterfrom
Sbragul26:fix/category-text-visibility-light-mode

Conversation

@Sbragul26

@Sbragul26 Sbragul26 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes #7796 and improves the visibility of category filter labels on the Integrations page in Light Mode.

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Style
    • Updated selected integration and integration title text to use the theme’s white color for improved visual consistency.

Signed-off-by: Sbragul26 <sbragul26@gmail.com>
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for PR #7797 removed.

This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits.

If needed, push a new commit to this PR to generate a fresh preview.

@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@Sbragul26 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@Rajesh-Nagarajan-11

Copy link
Copy Markdown
Member

Attach video & also add root cause please

@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@Sbragul26 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@Sbragul26

Sbragul26 commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

@KumarNirupam1 KumarNirupam1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The previous use of whiteToBlack could lead to poor contrast in light mode because the selected chip uses a dark green background. Switching both the selected category text and integration title to theme.white provides consistent readability across themes. I tested the affected states and the change looks correct.
LGTM 👍

@KhushamBansal KhushamBansal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This change updates text color properties in Integration.style.js. The .selected state and integration titles now use theme.white instead of theme.whiteToBlack for text color.

Changes

Text Color Fix

Layer / File(s) Summary
Update text color values
src/sections/Meshery/Meshery-integrations/Integration.style.js
The .selected state and integration title text color use theme.white instead of theme.whiteToBlack.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

Possibly related PRs

Suggested labels: project/meshery

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the category text contrast fix in Light Mode.
Linked Issues check ✅ Passed The color changes address issue #7796 by improving category filter label visibility in Light Mode.
Out of Scope Changes check ✅ Passed The two color changes are limited to the Integrations page contrast issue described in issue #7796.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/sections/Meshery/Meshery-integrations/Integration.style.js`:
- Line 107: Update the `.title` color declaration in the styled component to use
a theme color that provides WCAG 2.1 AA contrast against the hover background
`#00d3a9` in both themes, while preserving the existing hover styling.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d52a75e-77ce-4b05-87cb-f9c23a796d6f

📥 Commits

Reviewing files that changed from the base of the PR and between cbf1205 and cce2b84.

📒 Files selected for processing (1)
  • src/sections/Meshery/Meshery-integrations/Integration.style.js

.title {
line-height: 1.375rem;
color: ${(props) => props.theme.whiteToBlack};
color: ${(props) => props.theme.white};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Restore WCAG-compliant contrast for .title.

When the card is hovered, Line 147 sets the background to #00d3a9. theme.white does not provide sufficient contrast on that background. Use a theme value that meets WCAG AA in both modes, or change the hover background.

As per coding guidelines, JavaScript changes must meet WCAG 2.1 Level AA accessibility requirements.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/sections/Meshery/Meshery-integrations/Integration.style.js` at line 107,
Update the `.title` color declaration in the styled component to use a theme
color that provides WCAG 2.1 AA contrast against the hover background `#00d3a9`
in both themes, while preserving the existing hover styling.

Source: Coding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Category text not visible in Light Mode

5 participants