add options, allow passing SMC key#36
Open
DrPsychick wants to merge 21 commits intolavoiesl:masterfrom
Open
Conversation
Author
|
for reference see also https://logi.wiki/index.php/SMC_Sensor_Codes |
unify float/double
Owner
|
Sorry for not replying. I love this idea. I changed master a bit, which I think can help making this easier to do. Wanna try updating it? |
Author
|
Took a while to get it back to work, but also fixed some issues. Ready for review. Unfortunately, on my M1 Macs this does not produce any useful output anymore :( |
|
Can we add something like: at the top or in the /edit I just realized this must have been a breaking API change for political correctness? Yikes… 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning:
There is another PR which proposes to change the default keys read for CPU and GPU. This might not fit everybody (does not for me). So I wanted an option to pass the key that works for me.
TCXCas mentioned in #33 does not work on my older MacBook Pro 2011, butTC0PorTC0DorTC0Cwork. On a newer MBP 13", theTC0Ddoes not work. On my work MBP, theTC0DandTC0Cas well as theTG0PandTG0Ddon't work.To find out what works on a given machine, I added the option to dump all keys.
@lavoiesl : I'm happy to discuss any changes.