Open
Conversation
Member
|
you should rebase your master branch. |
topi314
requested changes
Feb 13, 2026
Comment on lines
+15
to
+18
| player := c.Lavalink.ExistingPlayer(*e.GuildID()) | ||
| if player != nil { | ||
| player.Destroy(ctx) | ||
| } |
Member
There was a problem hiding this comment.
the player is automatically destroyed on disconnect
| func (c *Commands) Forward(data discord.SlashCommandInteractionData, e *handler.CommandEvent) error { | ||
| ctx, cancel := context.WithTimeout(e.Ctx, 10*time.Second) | ||
| defer cancel() | ||
| player := c.Lavalink.ExistingPlayer(*e.GuildID()) |
Comment on lines
+15
to
+16
| ctx, cancel := context.WithTimeout(e.Ctx, 10*time.Second) | ||
| defer cancel() |
Member
There was a problem hiding this comment.
you can move this down where you actually use it
Comment on lines
+32
to
+37
| if nPos == cPos { | ||
| return e.CreateMessage(discord.MessageCreate{ | ||
| Content: "The player is already at position **`" + res.FormatDuration(lavalink.Duration(cPos)) + "`**", | ||
| Flags: discord.MessageFlagEphemeral, | ||
| }) | ||
| } |
| var vcID snowflake.ID | ||
|
|
||
| ch, ok := data.OptChannel("channel") | ||
| if ok && ch.Type == discord.ChannelTypeGuildVoice { |
| "github.com/lavalink-devs/lavalink-bot/internal/res" | ||
| ) | ||
|
|
||
| func (c *Commands) Rewind(data discord.SlashCommandInteractionData, e *handler.CommandEvent) error { |
Member
There was a problem hiding this comment.
same comments as with forward command
| "github.com/disgoorg/disgo/handler" | ||
| ) | ||
|
|
||
| func (c *Commands) SwapAutocomplete(e *handler.AutocompleteEvent) error { |
Member
There was a problem hiding this comment.
same things as with remove/move
| } | ||
| }) | ||
| if voiceStates <= 1 { | ||
| if atomic.LoadInt32(&voiceStates) <= 1 { |
| ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) | ||
| defer cancel() | ||
| if !event.Reason.MayStartNext() { | ||
| p.Destroy(ctx) |
| } | ||
| track, ok := h.MusicQueue.Next(p.GuildID()) | ||
| if !ok { | ||
| p.Destroy(ctx) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.