Re-validate first-time CTAN upload as a new package - #469
Merged
Conversation
A first-time CTAN upload passed the raw curl config content straight to the shell when re-validating an unknown package, so every form-string line failed silently and nothing was uploaded. Extract the config-file writing and curl command assembly into construct_ctan_command and call it on both the initial and the re-validation paths, so the second pass runs a real curl command.
Contributor
Author
|
@davidcarlisle please, take a look |
davidcarlisle
approved these changes
Jul 12, 2026
josephwright
approved these changes
Jul 12, 2026
muzimuzhi
reviewed
Jul 21, 2026
| print("Package not found on CTAN; re-validating as new package:") | ||
| uploadconfig.update = false | ||
| ctan_post = construct_ctan_post(uploadfile) | ||
| ctan_post = construct_ctan_command(uploadfile) .. ' https://ctan.org/submit/' |
Contributor
There was a problem hiding this comment.
Need to pass debugging status here too?
- ctan_post = construct_ctan_command(uploadfile) .. ' https://ctan.org/submit/'
+ ctan_post = construct_ctan_command(uploadfile, options["debug"]) .. ' https://ctan.org/submit/'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you upload a package to CTAN for the first time, the first validation pass comes back saying the package does not exist yet. l3build then flips
updateto false and validates again as a new package. That second pass was broken: it calledconstruct_ctan_post, which only returns the raw curl config (theform-string="..."lines), and handed that straight toshell. So instead of running curl, the shell tried to execute each config line as a command, every one failed on stderr, and becauseshellonly reads stdout the whole thing looked like it succeeded. The upload reported success and sent nothing.The initial pass got this right because it wrote the config to a file and built a real
curl --config <file> <url>command first. This pulls that file-writing and command-assembly step out intoconstruct_ctan_commandand uses it on both paths, so the re-validation now runs an actual curl command against the submit URL.Closes #468