Skip to content

Update to asn1 0.24.0#439

Merged
simo5 merged 1 commit intolatchset:mainfrom
Jakuje:asn1-0.24
May 4, 2026
Merged

Update to asn1 0.24.0#439
simo5 merged 1 commit intolatchset:mainfrom
Jakuje:asn1-0.24

Conversation

@Jakuje
Copy link
Copy Markdown
Contributor

@Jakuje Jakuje commented Apr 9, 2026

Description

Jeremy updated rust-asn1 to 0.24, which has a breaking change. This is mostly to double-check the change is correct before building RPM in epel10.

Checklist

  • Test suite updated
  • Rustdoc string were added or updated
  • CHANGELOG and/or other documentation added or updated
  • This is not a code change

Reviewer's checklist:

  • Any issues marked for closing are fully addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • A changelog entry is added if the change is significant
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible text
  • Doc string are properly updated

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Copy link
Copy Markdown
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
When will it land in Fedora proper?

@Jakuje
Copy link
Copy Markdown
Contributor Author

Jakuje commented Apr 9, 2026

LGTM. When will it land in Fedora proper?

@jeremycline can hopefully answer this. So far we have it only in epel10.

@jeremycline
Copy link
Copy Markdown
Contributor

I try to avoid as much packaging burden for myself as possible, so I'd prefer to wait until python-cryptography bumps and releases. My recommendation would be to carry a revert to this patch in Fedora, but otherwise I could submit a set of compat packages for cryptography.

My approach is do to what I want upstream and sort out Fedora's packaging separately since it's such a headache.

@jeremycline
Copy link
Copy Markdown
Contributor

FYI I'm updating asn1 to 0.24.1 in the f45-build-side-136452 side tag; since we cherry-picked this patch back for EPEL 10.3 I was planning to rebuild kryoptic into that side tag with this applied, if that's okay.

@simo5
Copy link
Copy Markdown
Member

simo5 commented Apr 29, 2026

FYI I'm updating asn1 to 0.24.1 in the f45-build-side-136452 side tag; since we cherry-picked this patch back for EPEL 10.3 I was planning to rebuild kryoptic into that side tag with this applied, if that's okay.

No problem

@simo5
Copy link
Copy Markdown
Member

simo5 commented May 4, 2026

0.24 finally landed in Fedora, merging this

@simo5 simo5 merged commit f18e60d into latchset:main May 4, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants