Skip to content

feat(vc): inline transcript from artifacts API and add keywords#1206

Merged
zhangjun-bytedance merged 1 commit into
mainfrom
feat/transcript_export
Jun 2, 2026
Merged

feat(vc): inline transcript from artifacts API and add keywords#1206
zhangjun-bytedance merged 1 commit into
mainfrom
feat/transcript_export

Conversation

@zhangjun-bytedance

@zhangjun-bytedance zhangjun-bytedance commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark-cli <domain> <command> flow works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Bug Fixes

    • Transcript for vc +notes is now reliably sourced from the consolidated artifacts response rather than a separate download endpoint.
  • Chores

    • Artifact/transcript workflow streamlined; transcript persistence now respects existing files unless --overwrite is used and dry-run messaging reflects transcript inclusion.
  • Tests

    • Integration tests updated to validate embedded transcript handling.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 321ad971-e7f7-4955-a499-8121eb806115

📥 Commits

Reviewing files that changed from the base of the PR and between 064dc6b and 97513a4.

📒 Files selected for processing (2)
  • shortcuts/vc/vc_notes.go
  • shortcuts/vc/vc_notes_test.go
🚧 Files skipped from review as they are similar to previous changes (2)
  • shortcuts/vc/vc_notes_test.go
  • shortcuts/vc/vc_notes.go

📝 Walkthrough

Walkthrough

Transcript handling for vc +notes --minute-tokens now reads the transcript from the minutes artifacts response and persists it to the canonical artifact path; scope, dry-run text, and tests were updated to reflect the inline-artifacts approach.

Changes

Transcript Artifact Inlining

Layer / File(s) Summary
Transcript persistence implementation
shortcuts/vc/vc_notes.go
fetchInlineArtifacts refactored to accept minute title and conditionally persist transcript via new saveTranscriptToFile helper when present in artifacts response. Old transcript download helper and artifacts-only implementation removed.
Configuration and integration
shortcuts/vc/vc_notes.go
Minute-tokens top-of-file comment updated, transcript-export scope removed from --minute-tokens, artifact merge call updated to use new transcript-capable fetchInlineArtifacts, and DryRun steps description adjusted to reflect transcript inclusion in artifacts.
Test infrastructure and integration tests
shortcuts/vc/vc_notes_test.go
artifactsStub helper extended to accept optional transcript parameter and include it in mocked artifacts response. Separate transcript endpoint stubs removed. Integration tests switched to artifacts-driven transcript content for transcript layout checks.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • larksuite/cli#1079: Modifies fetchInlineArtifacts/artifactsStub to parse additional fields from the minutes artifacts response; overlaps with artifacts-parsing changes.
  • larksuite/cli#604: Also touches vc +notes --minute-tokens transcript handling and artifact output path conventions.

Suggested labels

domain/vc, size/M

Suggested reviewers

  • zhaoleibd
  • calendar-assistant

Poem

A rabbit hops through artifact streams, 🐰
I gather lines and stitch the seams;
No separate fetch, the transcript's near,
Inlined and saved for all to hear —
Hopping bytes to disk with gentle beams.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is a template placeholder with no actual content; summary, changes, and test status are unfilled. Fill in the summary with concrete motivation, list actual changes made (transcript API refactoring, scope updates), and confirm test completion status before merging.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: inlining transcript from the artifacts API in the vc notes command.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/transcript_export

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact labels Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.19%. Comparing base (639259f) to head (97513a4).

Files with missing lines Patch % Lines
shortcuts/vc/vc_notes.go 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   69.17%   69.19%   +0.01%     
==========================================
  Files         630      630              
  Lines       59380    59361      -19     
==========================================
- Hits        41075    41073       -2     
+ Misses      14996    14986      -10     
+ Partials     3309     3302       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@97513a48799ce144ece3c35a275575e56d03d22e

🧩 Skill update

npx skills add larksuite/cli#feat/transcript_export -y -g

@zhangjun-bytedance zhangjun-bytedance merged commit 915cc62 into main Jun 2, 2026
21 checks passed
@zhangjun-bytedance zhangjun-bytedance deleted the feat/transcript_export branch June 2, 2026 02:36
@liangshuo-1 liangshuo-1 mentioned this pull request Jun 2, 2026
1 task
tuxedomm pushed a commit to zhumiaoxin/cli that referenced this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/vc PR touches the vc domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants