fix(test): Skip Tavily API key fill when global variable is loaded

[Cristhianzl]

OBJECTIVE: Fix flaky Market Research E2E test that fails in CI because TAVILY_API_KEY is auto-loaded as a global variable, replacing the input field with a badge.

CHANGES:

• Add count() check before fill() to skip when input is replaced by global variable badge
• Add comment explaining the race condition root cause

Summary by CodeRabbit

• Tests
  • Improved reliability of Market Research integration tests by adding safeguards to prevent input-filling failures when elements are dynamically replaced during environment variable loading.

[coderabbitai]

Walkthrough

A test file is modified to add a guard condition before filling the TAVILY_API_KEY input field. The input is now only filled if the element exists, preventing failures when the input element is replaced by a badge after the environment variable is loaded.

Changes

Cohort / File(s)	Summary
Test input handling src/frontend/tests/core/integrations/Market Research.spec.ts	Added guard condition to check if TAVILY_API_KEY input element exists (count > 0) before filling it, with explanatory comments. Prevents fill failures when the element is replaced by a badge after environment variable loads.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	PR adds a guard condition to fix a flaky test but lacks explicit regression tests verifying the guard condition behavior in both scenarios.	Add dedicated regression tests for when TAVILY_API_KEY is not auto-loaded (element present, fill called) and when it is auto-loaded (element absent, fill skipped).
Test File Naming And Structure	❓ Inconclusive	Cannot locate the test file referenced in the PR. Git commands show repository structure but the specific test file path is not accessible or identifiable from available shell commands.	Verify the exact test file path and provide direct access to the file contents for assessment.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main fix: skipping the Tavily API key fill when a global variable is loaded, which matches the core change in the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Quality And Coverage	✅ Passed	The test modification demonstrates good testing practices by adding a defensive count() guard before fill() to handle a race condition where auto-loaded environment variables replace the input element with a badge, improving robustness and maintainability.
Excessive Mock Usage Warning	✅ Passed	Playwright E2E test appropriately validates real user interactions with actual API calls without excessive mocking.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cz/fix-mr-test

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/frontend/tests/core/integrations/Market Research.spec.ts (1)

43-50: Good fix — consider an else-branch assertion for extra robustness.

The guard correctly prevents fill() from being called on a replaced element. One optional improvement: add an else branch that asserts the global-variable badge is actually visible. This way, if the input disappears for an unexpected reason (e.g., a regression), the test fails with a clear message instead of silently skipping the fill.

💡 Optional improvement

     const tavilyApiKeyInput = page.getByTestId("popover-anchor-input-api_key");
     if ((await tavilyApiKeyInput.count()) > 0) {
       await tavilyApiKeyInput.fill(process.env.TAVILY_API_KEY || "");
+    } else {
+      // Verify the key was loaded as a global variable (badge should be visible)
+      await expect(page.getByTestId("badge-api_key")).toBeVisible();
     }

Note: adjust the data-testid to match the actual badge selector used in your codebase.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Frontend Unit Test Coverage Report

Coverage Summary

Lines	Statements	Branches	Functions
	18.41% (5919/32150)	12.03% (3017/25069)	12.36% (855/6913)

Unit Test Results

Tests	Skipped	Failures	Errors	Time
2288	0 💤	0 ❌	0 🔥	32.524s ⏱️

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.20%. Comparing base (5052793) to head (73a334c).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (42.10%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11733   +/-   ##
=======================================
  Coverage   35.20%   35.20%           
=======================================
  Files        1521     1521           
  Lines       72927    72923    -4     
  Branches    10936    10936           
=======================================
  Hits        25675    25675           
+ Misses      45857    45852    -5     
- Partials     1395     1396    +1     

Flag	Coverage Δ
frontend	16.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 9 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.