fix(google-common): serialize tool choice modes for Vertex AI - #11266
Open
Zexu Jin (jackjin1997) wants to merge 1 commit into
Open
fix(google-common): serialize tool choice modes for Vertex AI#11266Zexu Jin (jackjin1997) wants to merge 1 commit into
Zexu Jin (jackjin1997) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f88f085 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11265
auto,any, andnonetool choices as the uppercase Vertex AI wire enumsANYfor forced function names while preservingallowedFunctionNamesChatVertexAIrequest payload in the existing integration testTest plan
pnpm --filter @langchain/google-common test— 8 files, 298 tests passed; typecheck cleanpnpm --filter @langchain/google-common --filter @langchain/google-vertexai build— passedpnpm exec oxfmt --check <changed files>— passedpnpm exec oxlint <changed TypeScript files>— passedReverse verification: the four focused request-formatting cases fail on current
mainwith lowercase modes, then pass with this patch.AI Disclosure
AI assisted with issue triage, test drafting, and implementation. The diff, reverse verification, and local checks were reviewed before submission.