Open
Conversation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kamil Tekiela tekiela246@gmail.com
Description
It seems as if mysqli was not reporting exceptions until now. I have enabled error reporting, which will make sure that every time an error happens an exception is thrown. This follows the same approach as the PDO adapter. I am not sure about abstracting exceptions as it seems PDOException is not abstracted in most places.
The background of this change is to bring it in line with the new default mysqli error reporting in PHP 8.1. Normally, to avoid BC we would add
mysqli_report(MYSQLI_REPORT_OFF)but in this case that line was missing previously and it seems like the project doesn't care about error handling. Therefore, it's better to enable error reporting for this extension to align it with PDO behaviour.Regarding the right place. In PDO error reporting is enabled after connection, but in mysqli it makes more sense to do it before.