[enhancement] tenant_level_security:install command#23
Open
mkmn wants to merge 2 commits intokufu:masterfrom
Open
[enhancement] tenant_level_security:install command#23mkmn wants to merge 2 commits intokufu:masterfrom
mkmn wants to merge 2 commits intokufu:masterfrom
Conversation
# Motivation When using this gem, you must first register `TenantLevelSecurity.current_tenante_id`. I want to make this step easy. # Changes Create InstallGenerator. This Generator copies initializer file. # Usage ``` rails g tenant_level_security:install ```
wata727
reviewed
Aug 6, 2024
| @@ -0,0 +1,11 @@ | |||
| module TenantLevelSecurity | |||
| module Generators | |||
| class InstallGenerator < ::Rails::Generators::Base | |||
Contributor
There was a problem hiding this comment.
This gem does not have an explicit dependency on Rails, so this reference is not always safe.
It might be better to make it work only if Rails is defined.
Strictly speaking, the classes and methods available will likely change depending on the version, so some version constraints may be necessary.
| @@ -0,0 +1,6 @@ | |||
| # Pass current tenant ID to `TenantLevelSecurity.current_tenant_id` block | |||
| # using ActiveSupport::CurrentAttributes, RequestStore, etc... | |||
| # TenantLevelSecurity.current_tenant_id { RequestStore.store[:current_tenant_id] } | |||
Contributor
There was a problem hiding this comment.
In this day and age, it may be better to recommend CurrentAttributes as the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using this gem, you must first register
TenantLevelSecurity.current_tenante_id.I want to make this step easy.
Changes
Create InstallGenerator.
This Generator copies initializer file.
Usage