fix(tunnel): use flexible OK check for Windows route command output

[bukx]

Problem

Fixes #11645

minikube tunnel on Windows endlessly retries adding a route because the code does a strict string equality check against " OK!\r\n". The Windows route command output can vary across different Windows versions, locales, and system configurations — meaning the exact whitespace or line endings may differ, causing the check to always fail and triggering an infinite retry loop.

Root Cause

In pkg/minikube/tunnel/route_windows.go, both EnsureRouteIsAdded and Cleanup used:

if message != " OK!\r\n" {
    return fmt.Errorf("error adding route: ...")
}

This strict equality fails when the output has slightly different formatting.

Fix

Replaced the strict equality check with a case-insensitive strings.Contains check for "OK" after trimming whitespace:

if !strings.Contains(strings.ToUpper(strings.TrimSpace(message)), "OK") {
    return fmt.Errorf("error adding route: unexpected output: %q", message)
}

This is robust across different Windows environments while still correctly detecting success vs failure.

Also improved error handling in EnsureRouteIsAdded to properly wrap the err from CombinedOutput using %w before checking the output string.

Testing

• Verified the fix handles " OK!\r\n", " OK!\n", "OK", and other valid success variations
• Verified failure cases (empty output, error messages) still return errors correctly

[k8s-ci-robot]

Invalid commit message issues detected

Invalid commit messages

Keywords which can automatically close issues and hashtag(#) mentions are not allowed.

• f3d87bf fix(tunnel): use flexible OK check for Windows route command output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[linux-foundation-easycla]

• ❌ The email address for the commit (f3d87bf) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bukx
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @bukx!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bukx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@bukx can you plz sign the CLA https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/56353740/22860/#/?version=2
and also print before/after this PR output with a clear example?