Fix logic for multi-node CNI warning.#22779
Fix logic for multi-node CNI warning.#22779toddliebenschutz-jones wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: toddliebenschutz-jones The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @toddliebenschutz-jones. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
Fixes #19665
This PR fixes the logic for the warning
Cluster was created without any CNI, adding a node to it might cause broken networking.which should be shown when adding a second node to a single-node cluster created without CNI.The warning log was added in #9875 in response to this comment thread #9875 (comment). The proposed solution was:
The warning should be shown when (1) the cluster is created with only a control plane node, and (2) CNI is not configured already. The corresponding change erroneously used an or instead of and.
Output diff
Before:
After: