Skip to content

Automated cherry pick of #18789: fix: discover NLB IPs with Terraform - #18790

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:release-1.37from
hakman:automated-cherry-pick-of-#18789-upstream-release-1.37
Sep 10, 2026
Merged

Automated cherry pick of #18789: fix: discover NLB IPs with Terraform#18790
kubernetes-prow[bot] merged 1 commit into
kubernetes:release-1.37from
hakman:automated-cherry-pick-of-#18789-upstream-release-1.37

Conversation

@hakman

@hakman hakman commented Sep 10, 2026

Copy link
Copy Markdown
Member

Cherry pick of #18789 on release-1.37.

#18789: fix: discover NLB IPs with Terraform

For details on the cherry pick process, see the cherry pick requests page.

What type of PR is this?


kOps 1.36 switched gossip workers to bootstrap through the NLB, exposing
an existing Terraform bug: the VPC task ID is unset, so NLB discovery
finds no IPs and falls back to an unresolvable gossip hostname.

Use the VPC ID returned by AWS for the NLB.
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2026
@kubernetes-prow kubernetes-prow Bot added the area/provider/aws Issues or PRs related to aws provider label Sep 10, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2026
@hakman

hakman commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-test

@kubernetes-prow
kubernetes-prow Bot merged commit 3c69999 into kubernetes:release-1.37 Sep 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants