Skip to content

🌱 Chore: harden git workflows#13442

Open
PrashantR30 wants to merge 1 commit intokubernetes-sigs:mainfrom
PrashantR30:main
Open

🌱 Chore: harden git workflows#13442
PrashantR30 wants to merge 1 commit intokubernetes-sigs:mainfrom
PrashantR30:main

Conversation

@PrashantR30
Copy link

@PrashantR30 PrashantR30 commented Mar 12, 2026

🌱 Harden GitHub Actions workflows

What this PR does / why we need it:

Hardens several CI workflows against credential leakage and privilege escalation:

  1. persist-credentials: false added to all actions/checkout steps that do not require pushing back to the repository. By default, actions/checkout persists the GITHUB_TOKEN in .git/config, which can be inadvertently leaked if a workflow uploads artifacts.

  2. pr-verify.yaml: pull_request_target replaced with pull_request : this is the most significant fix. pull_request_target runs with base-repo privileges and access to secrets. Since this workflow checks out repo code and executes ./hack/verify-pr-title.sh, a malicious fork PR could modify that script and run arbitrary code with elevated privileges. Switching to pull_request removes that risk entirely, as title validation requires no elevated permissions.

  3. permissions: {} added to pr-verify.yaml which was missing an explicit permissions block.

  4. fetch-depth: 1 added to weekly-md-link-check.yaml and weekly-security-scan.yaml as full git history is unnecessary for link checking and security scanning.

Which issue(s) this PR fixes:
Fixes #

Changes:

File Change
pr-golangci-lint.yaml persist-credentials: false
pr-md-link-check.yaml persist-credentials: false
pr-verify.yaml pull_request_target replaced by pull_request, permissions: {}, persist-credentials: false
weekly-md-link-check.yaml persist-credentials: false, fetch-depth: 1
weekly-security-scan.yaml persist-credentials: false, fetch-depth: 1
weekly-test-release.yaml persist-credentials: false

/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

Welcome @PrashantR30!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @PrashantR30. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants