add build and version information if shallow copy or fork#13417
add build and version information if shallow copy or fork#13417egypcio wants to merge 17 commits intokubernetes-sigs:mainfrom
Conversation
- before this patch, code built on shallow copies but didn't provide
proper versioning information (e.g.: git commit, or tree state);
- we now inject data from the git repository into "version" commands'
output
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
- tree could be clean, but clone is a shallow copy anyway;
- rework how the interruption of a build is done (we need at least a
tag for that proper parsing)
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
This reverts commit c7082f2.
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
Signed-off-by: vinícius <651124+egypcio@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @egypcio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/area clusterctl |
|
/area misc |
What this PR does / why we need it:
by merging this PR, we would:
hack/version.sh;clusterctl);Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):motivation behind these changes should fix:
How to reproduce
reproduce.sh
clusterctl versioncurrent outputclusterctl versionproposed output, if shallow or forkmanagersbuild target gets also the benefits of proposed changes