🌱 Migrate from Requeue to RequeueAfter in kcp#13028
🌱 Migrate from Requeue to RequeueAfter in kcp#13028k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
There was a problem hiding this comment.
Mix them without separating.
There was a problem hiding this comment.
I just intentionally added these in the PR merged yesterday. Please keep them (please see the godocs I explicitly added to the nolint statements)
(please revert all changes to this file, this util will soon'ish also be used in other controller / repos. It has to handle Requeue appropriately and must have the corresponding unit test coverage for it)
k8s-ci-robot
added
the
approved
There was a problem hiding this comment.
I just intentionally added these in the PR merged yesterday. Please keep them (please see the godocs I explicitly added to the nolint statements)
(please revert all changes to this file, this util will soon'ish also be used in other controller / repos. It has to handle Requeue appropriately and must have the corresponding unit test coverage for it)
|
/hold Until the findings are resolved |
k8s-ci-robot
added
the
do-not-merge/hold
sivchari
force-pushed
the
migrate-kcp-requeue-to-requeueafter
branch
from
952c490 to
be6829d
Compare
|
I addressed review findings. |
|
@sivchari Looks like unit tests are failing :) |
sbueringer
left a comment
sbueringer
left a comment
There was a problem hiding this comment.
Only reviewed the prod code. One finding for that
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
force-pushed
the
migrate-kcp-requeue-to-requeueafter
branch
from
be6829d to
d92adfc
Compare
|
/area provider/control-plane-kubeadm |
k8s-ci-robot
added
area/provider/control-plane-kubeadm
|
Thank you very much! /lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: b3a8a0ac15a16a36c8338a1f405e7321602ebc93 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12272