Skip to content

✨ Allow overriding image name in clusterctl config#13014

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
alexander-demicev:allowimage
Dec 30, 2025
Merged

✨ Allow overriding image name in clusterctl config#13014
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
alexander-demicev:allowimage

Conversation

@alexander-demicev
Copy link
Contributor

@alexander-demicev alexander-demicev commented Nov 20, 2025

What this PR does / why we need it:
This PR adds a name override option for the clusterctl config:

images:
  cluster-api:
    repository: myorg.io/local-repo
    name: mirrored-cluster-api-controller
    tag: v1.10.6

We have use-case where using clusterctl config is the best option to override CAPI image name for some air-gapped scenarios where image is retagged with a slightly different name.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area clusterctl

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2025
@alexander-demicev
Copy link
Contributor Author

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl and removed do-not-merge/needs-area PR is missing an area label labels Nov 20, 2025
@salasberryfin
Copy link
Contributor

Thanks @alexander-demicev.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: f0443ca25466e6ce217493cb8df62c259ca89dff

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2025
@kkaempf kkaempf moved this to Blocked in CAPI / Turtles Dec 17, 2025
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main-gke

@sivchari
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: ba338acf6bb341f85aaae023bbf2265b132c56fe

@sbueringer
Copy link
Member

/assign @fabriziopandini

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and to all the folks that reviewed it so far!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit a6a8c16 into kubernetes-sigs:main Dec 30, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Dec 30, 2025
@github-project-automation github-project-automation bot moved this from Blocked to Done in CAPI / Turtles Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants