:sparkles: Add support to clusterctl for inserting workload kubeconfig into an existing kubeconfig file by dmvolod · Pull Request #11942 · kubernetes-sigs/cluster-api

dmvolod · 2025-03-07T17:34:06Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10133

k8s-ci-robot · 2025-03-07T17:34:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dmvolod · 2025-03-07T17:34:27Z

/area clusterctl

dmvolod · 2025-03-25T11:25:37Z

@fabriziopandini could you please to have a look at this PR when possible
Thanks in advance

sivchari

I left one nits, but otherwise looks good.
/lgtm

sivchari · 2025-04-12T10:33:35Z

cmd/clusterctl/cmd/get_kubeconfig_test.go

+	}
+}
+
+const workloadKubeconfig = `apiVersion: v1


Let's separate to other file. We can embed these data to use go:embed.
It's more readable.

Totally agree with you and embed is my preferable way for big data values in tests.
But I can see, that most of the test approaches in the Cluster API tests are using constants.

Then, let's move constants to embedded way after it or asynchronously.

Fixed, please review

k8s-ci-robot · 2025-04-12T10:35:46Z

LGTM label has been added.

Details

Git tree hash: 9989754b9f0d1c43516c96d2d986b122b165cc56

k8s-ci-robot · 2025-04-15T05:14:29Z

New changes are detected. LGTM label has been removed.

sivchari

Thanks for updating. I left nits, PTAL 🙏

sivchari · 2025-04-16T03:54:48Z

cmd/clusterctl/cmd/get_kubeconfig_test.go

+//go:embed testdata/existsing-kubeconfig.yaml
+var existingKubeconfig string
+
+//go:embed testdata/workload-kubeconfig.yaml
+var workloadKubeconfig string
+
+//go:embed testdata/joined-kubeconfig.yaml
+var joinedKubeconfig string


Suggested change

//go:embed testdata/existsing-kubeconfig.yaml

var existingKubeconfig string

//go:embed testdata/workload-kubeconfig.yaml

var workloadKubeconfig string

//go:embed testdata/joined-kubeconfig.yaml

var joinedKubeconfig string

var (

//go:embed testdata/existsing-kubeconfig.yaml

existingKubeconfig string

//go:embed testdata/workload-kubeconfig.yaml

workloadKubeconfig string

//go:embed testdata/joined-kubeconfig.yaml

joinedKubeconfig string

)

Just a bit easier to read.

Ok, will fix

sivchari · 2025-04-16T03:58:34Z

cmd/clusterctl/cmd/get_kubeconfig_test.go

+var existingKubeconfig string
+
+//go:embed testdata/workload-kubeconfig.yaml
+var workloadKubeconfig string


Suggested change

var workloadKubeconfig string

var singleWorkloadKubeconfig string

Ok, will fix

sivchari · 2025-04-16T03:58:45Z

cmd/clusterctl/cmd/get_kubeconfig_test.go

+var workloadKubeconfig string
+
+//go:embed testdata/joined-kubeconfig.yaml
+var joinedKubeconfig string


Suggested change

var joinedKubeconfig string

var multipleWorkloadKubeconfig string

Ok, will fix

… existing kubeconfig file

k8s-triage-robot · 2025-07-15T05:33:41Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

dmvolod · 2025-07-15T06:34:24Z

/remove-lifecycle stale

k8s-triage-robot · 2025-08-14T07:19:49Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-09-13T07:25:36Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-09-13T07:25:42Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dmvolod · 2025-09-17T09:22:29Z

/reopen

k8s-ci-robot · 2025-09-17T09:22:35Z

@dmvolod: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dmvolod · 2025-09-17T09:22:42Z

/remove-lifecycle rotten

dmvolod · 2025-09-17T09:32:48Z

/test pull-cluster-api-test-main

k8s-ci-robot · 2025-09-17T09:43:48Z

@dmvolod: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-test-main	`93af1ed`	link	true	`/test pull-cluster-api-test-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sbueringer · 2025-11-11T17:04:53Z

Not sure if this should be in scope for clusterctl. Wondering if kubectl has some feature for this

/cc @fabriziopandini

k8s-triage-robot · 2026-02-09T17:52:03Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2025

k8s-ci-robot requested review from JoelSpeed and richardcase March 7, 2025 17:34

k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Mar 7, 2025

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2025

k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl and removed do-not-merge/needs-area PR is missing an area label labels Mar 7, 2025

dmvolod force-pushed the issue-10133 branch from 67e6ed2 to 3de43e6 Compare March 10, 2025 06:44

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2025

dmvolod force-pushed the issue-10133 branch 2 times, most recently from c014c6e to c43c52a Compare March 10, 2025 17:33

sivchari reviewed Apr 12, 2025

View reviewed changes

k8s-ci-robot assigned sivchari Apr 12, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2025

dmvolod force-pushed the issue-10133 branch from c43c52a to 334b967 Compare April 15, 2025 05:14

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2025

k8s-ci-robot requested a review from sivchari April 15, 2025 05:14

dmvolod force-pushed the issue-10133 branch from 334b967 to ccb7453 Compare April 15, 2025 05:27

sivchari reviewed Apr 16, 2025

View reviewed changes

✨ Add support to clusterctl for inserting workload kubeconfig into an…

93af1ed

… existing kubeconfig file

dmvolod force-pushed the issue-10133 branch from ccb7453 to 93af1ed Compare April 16, 2025 05:13

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 14, 2025

k8s-ci-robot closed this Sep 13, 2025

k8s-ci-robot reopened this Sep 17, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 17, 2025

k8s-ci-robot requested a review from fabriziopandini November 11, 2025 17:04

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2026

	var workloadKubeconfig string
	var singleWorkloadKubeconfig string

	var joinedKubeconfig string
	var multipleWorkloadKubeconfig string

Conversation

dmvolod commented Mar 7, 2025

Uh oh!

k8s-ci-robot commented Mar 7, 2025

Uh oh!

dmvolod commented Mar 7, 2025

Uh oh!

dmvolod commented Mar 25, 2025

Uh oh!

sivchari left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 12, 2025

Uh oh!

k8s-ci-robot commented Apr 15, 2025

Uh oh!

sivchari left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Jul 15, 2025

Uh oh!

dmvolod commented Jul 15, 2025

Uh oh!

k8s-triage-robot commented Aug 14, 2025

Uh oh!

k8s-triage-robot commented Sep 13, 2025

Uh oh!

k8s-ci-robot commented Sep 13, 2025

Uh oh!

dmvolod commented Sep 17, 2025

Uh oh!

k8s-ci-robot commented Sep 17, 2025

Uh oh!

dmvolod commented Sep 17, 2025

Uh oh!

dmvolod commented Sep 17, 2025

Uh oh!

k8s-ci-robot commented Sep 17, 2025

Uh oh!

sbueringer commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-triage-robot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sbueringer commented Nov 11, 2025 •

edited

Loading