Skip to content

🌱 e2e: stream logs for CPI and CSI to artifacts - #4109

Open
Dasmat13 wants to merge 6 commits into
kubernetes-sigs:mainfrom
Dasmat13:fix-issue-2614
Open

🌱 e2e: stream logs for CPI and CSI to artifacts#4109
Dasmat13 wants to merge 6 commits into
kubernetes-sigs:mainfrom
Dasmat13:fix-issue-2614

Conversation

@Dasmat13

@Dasmat13 Dasmat13 commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Fixes: #2614

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 23, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Welcome @Dasmat13!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2026
@kubernetes-prow

kubernetes-prow Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Hi @Dasmat13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from rvanderp3 and srm09 July 23, 2026 00:16
@kubernetes-prow

kubernetes-prow Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign srm09 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Dasmat13
e2e: stream logs for CPI and CSI to artifacts
6bea311 
This utilizes WatchDaemonSetLogsByLabelSelector and WatchDeploymentLogsByLabelSelector to gather the logs of the CPI and CSI pods during e2e tests for better debugging. We use a background goroutine tied to the spec namespace context that polls for the workload cluster to become available and starts streaming logs.
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 23, 2026
@sbueringer

sbueringer commented Jul 23, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2026
@Dasmat13 Dasmat13 changed the title e2e: stream logs for CPI and CSI to artifacts test: stream logs for CPI and CSI to artifacts Jul 23, 2026
@Dasmat13 Dasmat13 changed the title test: stream logs for CPI and CSI to artifacts 🌱 e2e: stream logs for CPI and CSI to artifacts Jul 23, 2026
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2026
@Dasmat13

Dasmat13 commented Jul 23, 2026

Copy link
Copy Markdown
Author

/retest

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 23, 2026
sbueringer
sbueringer reviewed Jul 23, 2026
View reviewed changes
Comment thread test/e2e/e2e_suite_test.go Outdated
@Dasmat13

Dasmat13 commented Jul 24, 2026

Copy link
Copy Markdown
Author

Hi @sbueringer and @rvanderp3, I've addressed the review feedback and pushed the updated implementation. CI is passing, so I'd appreciate another review when you have time. Thanks!

@sbueringer

sbueringer commented Jul 31, 2026

Copy link
Copy Markdown
Member

Hi @sbueringer and @rvanderp3, I've addressed the review feedback and pushed the updated implementation. CI is passing, so I'd appreciate another review when you have time. Thanks!

As far as I can tell the code didn't change since the last review

@Dasmat13

Dasmat13 commented Jul 31, 2026

Copy link
Copy Markdown
Author

my bad! realized I forgot to push the commit with the refactor. just pushed it now, please have another look when you get a chance

@Dasmat13
Dasmat13 requested a review from sbueringer August 2, 2026 20:07
@Dasmat13 Dasmat13 mentioned this pull request Aug 5, 2026
Closed
@Dasmat13

Dasmat13 commented Aug 8, 2026

Copy link
Copy Markdown
Author

Hi @sbueringer @rvanderp3, quick ping — the refactor is pushed and all CI is green now. Would appreciate another look when you get a chance. Thanks!

@Dasmat13

Dasmat13 commented Aug 8, 2026

Copy link
Copy Markdown
Author

Hi @camilamacedo86 @vitorfloriano, quick ping — I’ve addressed the review feedback. Would appreciate another look when you get a chance. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3
@srm09 srm09 Awaiting requested review from srm09
@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e: Store logs of daemonsets during e2e tests

2 participants

@Dasmat13 @sbueringer