Fix PVC finalizer update retrying on conflict

[akalenyu]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Today, this is never retried since we lose the conflict error characteristics once we return a new error type.

Which issue(s) this PR fixes:

Fixes #957

Special notes for your reviewer:
Revival of #1299

Does this PR introduce a user-facing change?:

Fix PVC finalizer update retrying on conflict

[k8s-ci-robot]

Hi @akalenyu. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[akalenyu]

/cc @Fricounet

[k8s-ci-robot]

@akalenyu: GitHub didn't allow me to request PR reviews from the following users: Fricounet.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Fricounet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Fricounet]

Looks good from my end. I don't have write access to the repository though so I can't really approve unfortunately

[akalenyu]

Looks good from my end. I don't have write access to the repository though so I can't really approve unfortunately

That's fine
/cc @xing-yang

[sunnylovestiramisu]

/ok-to-test

[akalenyu]

/retest

[akalenyu]

/cc @gnufied

[akalenyu]

gentle ping 🙏 @xing-yang @gnufied

[nixpanic]

/lgtm

[nixpanic]

/unassign
/assign xing-yang

[gnufied]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment