[v8.5.0] Create Helm Chart from Static Manifests#1325
[v8.5.0] Create Helm Chart from Static Manifests#1325hswong3i wants to merge 2 commits intokubernetes-csi:masterfrom
Conversation
|
Hi @hswong3i. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Sorry @TerryHowe may we continuous the review for #1285 with this new PR? |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
I'm sure there's a lot of value in getting this in a Helm Chart |
971c24b to
f8c31ee
Compare
265cbf1 to
c95c6d5
Compare
|
/ok-to-test |
|
cc @xing-yang |
|
Seems like our CI officially failing? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hswong3i The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Sorry, we won't be able to maintain a Helm Chart in the external-snapshotter repo. You can keep this in your own repo. |
|
@xing-yang recall the original design of this PR:
So this is just the 1st step for Helm support, by manually run the |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Update cross-referenced sidecar images to latest stable releases: - csi-provisioner: v6.1.0 -> v6.2.0 - csi-snapshotter: v8.4.0 -> v8.5.0 - snapshot-controller: v8.4.0 -> v8.5.0 - hostpathplugin: v1.11.0 -> v1.17.1 Note: snapshot-conversion-webhook left at v8.0.1 as no published images exist in registry.k8s.io for this component. Signed-off-by: Humble Devassy Chirammal <humble.devassy@gmail.com>
**What type of PR is this?** /kind feature **What this PR does / why we need it**: This PR convert our static deployment manifests from `deploy/kubernetes/*` into Helm Charts under `charts/*`, by running a convert script under `deploy/util/chart-releaser.sh`. Moreover, it handle the chart release with branch `gh-pages`, by integrate with https://github.com/helm/chart-releaser-action. The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-external-snapshotter/index.yaml, by: helm repo add external-snapshotter https://alvistack.github.io/kubernetes-csi-external-snapshotter helm repo update helm search repo external-snapshotter Before each stable tag release, maintainers only required to: 1. Run the `./deploy/util/chart-releaser.sh` and update templates under `charts/*/templates/*` 2. Double confirm `charts/*/values.yml` with correct values, e.g. image tags 3. `git add --all --force charts/* && git commit` Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
|
@hswong3i: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR convert our static deployment manifests from
deploy/kubernetes/*into Helm Charts undercharts/*, by running a convert script underdeploy/util/chart-releaser.sh.Moreover, it handle the chart release with branch
gh-pages, by integrate with https://github.com/helm/chart-releaser-action.The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-external-snapshotter/index.yaml, by:
Before each stable tag release, maintainers only required to:
./deploy/util/chart-releaser.shand update templates undercharts/*/templates/*charts/*/values.ymlwith correct values, e.g. image tagsgit add --all --force charts/* && git commitWhich issue(s) this PR fixes:
Fixes #551
Fixes #622
Fixes #751