Skip to content

documentation(kserve): add upgrade notes for v0.16.x to v0.17.0 migration#3420

Open
abdullahpathan22 wants to merge 1 commit intokubeflow:masterfrom
abdullahpathan22:docs/kserve-v0.17-upgrade-guide
Open

documentation(kserve): add upgrade notes for v0.16.x to v0.17.0 migration#3420
abdullahpathan22 wants to merge 1 commit intokubeflow:masterfrom
abdullahpathan22:docs/kserve-v0.17-upgrade-guide

Conversation

@abdullahpathan22
Copy link
Copy Markdown

Summary

This PR adds upgrade notes for users migrating from KServe v0.16.x to v0.17.0 within Kubeflow manifests.

This is a companion to #3406 which upgrades the KServe manifests to v0.17.0.

What this documents

Related

Contributor Checklist

  • All commits are signed-off (DCO)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new top-level upgrade guide documenting manual steps and known issues when migrating Kubeflow Manifests’ KServe deployment from v0.16.x to v0.17.0.

Changes:

  • Introduces UPGRADING.md with KServe v0.16.x → v0.17.0 upgrade notes, including a required pre-delete of a ClusterRoleBinding.
  • Documents the upstream v0.17.0 tag issue (missing install files) and how this repository sources manifests.
  • Notes a webhook certificate SAN fix and provides example apply commands for full vs. component-only upgrades.

Comment thread UPGRADING.md Outdated
Comment thread UPGRADING.md Outdated
```

**Why this is required:**
In KServe v0.17.0, the `llmisvc` role bindings were restructured. The old `ClusterRoleBinding` from v0.16.x conflicts with the new ones defined in the v0.17.0 manifests. If you do not delete it manually, the `kubectl apply` (or `kustomize build | kubectl apply`) will fail due to naming conflicts.
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text says kubectl apply will fail "due to naming conflicts" if the old ClusterRoleBinding is not deleted. Kubernetes allows updates to existing resources with the same name; the typical failure mode here is an immutable-field change on the existing ClusterRoleBinding (e.g., roleRef/subjects cannot be updated). Please reword this to describe the actual error condition users will hit so the guidance is technically accurate.

Suggested change
In KServe v0.17.0, the `llmisvc` role bindings were restructured. The old `ClusterRoleBinding` from v0.16.x conflicts with the new ones defined in the v0.17.0 manifests. If you do not delete it manually, the `kubectl apply` (or `kustomize build | kubectl apply`) will fail due to naming conflicts.
In KServe v0.17.0, the `llmisvc` role bindings were restructured. The old `ClusterRoleBinding` from v0.16.x is incompatible with the new ones defined in the v0.17.0 manifests. If you do not delete it manually, the `kubectl apply` (or `kustomize build | kubectl apply`) will fail because Kubernetes does not allow updating immutable fields on an existing `ClusterRoleBinding` (such as `roleRef` or `subjects`).

Copilot uses AI. Check for mistakes.
Comment thread UPGRADING.md Outdated
@juliusvonkohout
Copy link
Copy Markdown
Member

juliusvonkohout commented Mar 23, 2026

Hello and thank you for the PR. Can you make it minimalistic and fitting in style with the existing upgrading and extending section?. https://github.com/kubeflow/manifests?tab=readme-ov-file#upgrading-and-extending is the place to add aminimalistic version. Please do not add a separate file and sign your commits.

This comment was marked as resolved.

@abdullahpathan22 abdullahpathan22 force-pushed the docs/kserve-v0.17-upgrade-guide branch from 4447fae to babbd34 Compare March 23, 2026 10:37
@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Mar 23, 2026
@abdullahpathan22
Copy link
Copy Markdown
Author

abdullahpathan22 commented Mar 23, 2026

Thanks for the feedback! Working on it

@abdullahpathan22 abdullahpathan22 force-pushed the docs/kserve-v0.17-upgrade-guide branch 3 times, most recently from 5a790cb to f46d319 Compare March 23, 2026 11:17
@abdullahpathan22
Copy link
Copy Markdown
Author

@juliusvonkohout Please check now i think i have made necessary changes.

@juliusvonkohout
Copy link
Copy Markdown
Member

You have to sign your commits or the DCO test fails

Signed-off-by: abdullahpathan22 <abdullahpathan22@users.noreply.github.com>
@abdullahpathan22 abdullahpathan22 force-pushed the docs/kserve-v0.17-upgrade-guide branch from f46d319 to de40af0 Compare March 23, 2026 12:11
@abdullahpathan22
Copy link
Copy Markdown
Author

@juliusvonkohout i have done the needfull.

@juliusvonkohout juliusvonkohout changed the title docs(kserve): add upgrade notes for v0.16.x to v0.17.0 migration documentation(kserve): add upgrade notes for v0.16.x to v0.17.0 migration Mar 23, 2026
@juliusvonkohout
Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christian-heusel
Copy link
Copy Markdown
Contributor

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants