chore: run make gen and remove deprecated handler code - #3102
Merged
Conversation
There were build errors on main after kubeflow#3086. Updating the generated code and removing the code to handle removed parameters. Signed-off-by: Paul Boyd <paul@pboyd.io>
Member
|
/lgtm Thanks! |
…s params Commit ea2cd96 removed the deprecated `recommended` bool from FindModels and the duplicate `artifactType2` slice from GetAllModelArtifacts, but left the test file calling the old signatures, breaking compilation. Signed-off-by: Paul Boyd <paul@pboyd.io>
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonburdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were build errors on main after #3086. Updating the generated code and removing the code to handle removed parameters.
How Has This Been Tested?
make image/buildMerge criteria:
DCOcheck)