Skip to content

Add scroll inside serverJson card in MCP details page - #3099

Merged
google-oss-prow[bot] merged 3 commits into
kubeflow:mainfrom
ppadti:fix-serverJson
Aug 19, 2026
Merged

Add scroll inside serverJson card in MCP details page#3099
google-oss-prow[bot] merged 3 commits into
kubeflow:mainfrom
ppadti:fix-serverJson

Conversation

@ppadti

@ppadti ppadti commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Add a scroll inside serverJson and show all the fields of serverJson inside the card

Screen.Recording.2026-08-19.at.2.07.53.PM.mov

How Has This Been Tested?

Run the application in mock mode and check the MCP details page for serverJson card

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: ppadti <ppadti@redhat.com>
@ppadti

ppadti commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@manaswinidas manaswinidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merge-blocking. Dummy div should be PanelMainBody; Cypress assertions are tautological and never cover scroll; copy button lives inside the overflow.

Comment thread clients/ui/frontend/src/app/pages/mcpCatalog/screens/McpServerDetailsView.tsx Outdated
ppadti added 2 commits August 19, 2026 14:06
Signed-off-by: ppadti <ppadti@redhat.com>
Signed-off-by: ppadti <ppadti@redhat.com>
@manaswinidas

Copy link
Copy Markdown
Contributor

/retest

@manaswinidas manaswinidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The maxHeight is irking me - but we can revisit it. We can use flex/isFilled + overflow: auto. @ppadti what do you think ?

@manaswinidas

Copy link
Copy Markdown
Contributor

/approve

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot merged commit 3bb8cf2 into kubeflow:main Aug 19, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants