Add scroll inside serverJson card in MCP details page - #3099
Merged
Conversation
Signed-off-by: ppadti <ppadti@redhat.com>
Contributor
Author
|
/retest |
manaswinidas
left a comment
Contributor
There was a problem hiding this comment.
Not merge-blocking. Dummy div should be PanelMainBody; Cypress assertions are tautological and never cover scroll; copy button lives inside the overflow.
Signed-off-by: ppadti <ppadti@redhat.com>
Signed-off-by: ppadti <ppadti@redhat.com>
Contributor
|
/retest |
manaswinidas
left a comment
Contributor
There was a problem hiding this comment.
/lgtm
The maxHeight is irking me - but we can revisit it. We can use flex/isFilled + overflow: auto. @ppadti what do you think ?
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 19, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a scroll inside serverJson and show all the fields of serverJson inside the card
Screen.Recording.2026-08-19.at.2.07.53.PM.mov
How Has This Been Tested?
Run the application in mock mode and check the MCP details page for serverJson card
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes