fix(ui): remove _lastModified workaround from timestamp bump utils#2710
Merged
google-oss-prow[bot] merged 1 commit intoMay 15, 2026
Merged
Conversation
Contributor
Author
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ppadti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: manaswinidas <[email protected]>
13da6c3 to
8a8991e
Compare
Contributor
|
/lgtm |
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The MR API previously had a bug where PATCH calls didn't always update
lastUpdateTimeSinceEpochfor RegisteredModels and ModelVersions. A workaround was added in the frontend that injected a_lastModifiedcustom property into the PATCH body to force a timestamp update.Now that the backend correctly updates
lastUpdateTimeSinceEpochon every PATCH call (via the generic repositorySavemethod), this workaround is no longer needed.Changes
customPropertiesobject (including_lastModified) frombumpModelVersionTimestampandbumpRegisteredModelTimestampinupdateTimestamps.ts. Both now send only{ state: ModelState.LIVE }.customPropertiesspreading._lastModifiedfilter ingetProperties(utils.ts) to reflect it's now a legacy filter. The filter is intentionally kept so existing models don't suddenly show a confusing_lastModifiedproperty after upgrade.How Has This Been Tested?
updateTimestamps.test.ts— all 8 tests passutils.spec.ts— all 66 tests pass (including the_lastModifiedfilter test)To verify end-to-end: edit the details of a ModelVersion (e.g. change its description, labels, or properties) and verify that its associated RegisteredModel has its last modified time updated and appears at the top of the list when sorting by last modified time.
Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.If you have UI changes